-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore bookmark icon url when browser gets bookmark form sync cloud #4420
Conversation
Some details.
which get us into https://source.chromium.org/chromium/chromium/src/+/79.0.3945.130:components/sync_bookmarks/bookmark_specifics_conversions.cc;l=295 |
… brave-browser#7893
df425d7
to
e131636
Compare
Chromium sends both icon_url and icon_data in the same time and expects to have them either both or either none of them. Here is a place where Chromium creates
It was a time when we put bookmark icon data into SyncRecord metadata to allow to get the boookmark instantly.
I marking this PR as ready for review to allow issue be fixed asap. For the matter of icon, |
Merging as this is required to unblock some items for 1.3. CI has passed and PR has been peer reviewed 😄👍 |
Intended t o fix brave/brave-browser#7893
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
See steps in brave/brave-browser#7893
Reviewer Checklist:
After-merge Checklist:
changes has landed on.