Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed debug build for Windows #4304

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Fixed debug build for Windows #4304

merged 1 commit into from
Jan 4, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Jan 3, 2020

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik requested a review from bridiver January 3, 2020 17:57
@samartnik
Copy link
Contributor Author

Fixes brave/brave-browser#7524

browser/BUILD.gn Outdated
@@ -140,7 +140,6 @@ source_set("browser_process") {
"//brave/components/p3a",
"//brave/components/resources",
"//brave/components/services:brave_content_manifest_overlays",
"//brave/services/network/public/cpp",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed this should be fixed by making //brave/services/network/public/cpp/BUILD.gn a component or jumbo_component

@yrliou yrliou added this to the 1.5.x - Nightly milestone Jan 3, 2020
@samartnik samartnik merged commit 60fcb90 into master Jan 4, 2020
@samartnik samartnik deleted the windows_debug_fix branch January 4, 2020 18:01
mkarolin pushed a commit that referenced this pull request Jan 31, 2020
mkarolin pushed a commit that referenced this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants