Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes inline tip for twitter (uplift to 1.3.x) #4220

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Fixes inline tip for twitter (uplift to 1.3.x) #4220

merged 1 commit into from
Dec 13, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Dec 12, 2019 •
edited by bsclifton
Loading

Uplift of #4215
Fixes brave/brave-browser#7324

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Dec 12, 2019
@brave-builds brave-builds added this to the 1.3.x - Dev milestone Dec 12, 2019
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron, NejcZdovc and srirambv December 12, 2019 21:05
@kjozwiak
Copy link
Member

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4215_twitter-inline_1.3.x/1/execution/node/698/log/ failing.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Dec 13, 2019
@bsclifton
Copy link
Member

Seeing a bunch of 19:00:20 error: Connection to server timed out. Gonna restart again here...

bsclifton
bsclifton approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit a8b8780 into 1.3.x Dec 13, 2019
@bsclifton bsclifton deleted the pr4215_twitter-inline_1.3.x branch December 13, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @bsclifton @brave-browser-releases