Issue 7044: Do not import cookies from Chrome and Firefox.

[iefremov]

Note: we do not import cookies from Safari, so nothing to disable.

Fix brave/brave-browser#7044

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[darkdh]

we also need to remove cookie option from importer_list.cc which means patch for Firefox and cookies detection in ChromeImporterCanImport for Chrome to prevent option shows up in import dialog

[iefremov]

@darkdh thanks, fixed

[darkdh]

lgtm

[iefremov]

@bridiver please take a look

[iefremov]

Agreed with @tomlowenthal to do not touch BraveImporter in this PR

[bridiver]

Changes look good, just checking to make sure we are ok with dropping all cookie import vs just dropping 3rd-party cookie import

[fmarier]

Just to confirm, we are talking about dropping all cookies (first and third-party).

This also came up at the Initiatives meeting where Brendan and David were of the opinion that we should just remove that functionality entirely (as opposed to disabling it by default and letting users enable it if they want) to avoid the privacy and compatibility problems we have seen with these.

[bsclifton]

@fmarier correct- we want to remove the ability to import cookies completely 👍 (per @BrendanEich, don't even show the checkbox during manual import)

[bsclifton]

Will try to review soon! Important to try both manual import and also import via the brave://welcome wizard

[bsclifton]

@iefremov we got the go-ahead to remove Muon import, if you wanted to do that also 👍

Either here or in a separate PR (I'd be OK including with this one, as a distinct commit)

[bsclifton]

Works great! Tested with both Chrome and Firefox... also tested regular import case (from settings) and then import from Wizard. Everything worked as expected 😄

[bsclifton]

@iefremov only one problem: getting unit test failure for:

1 test failed:
    ChromeImporterTest.ImportCookies (../../brave/utility/importer/chrome_importer_unittest.cc:173)

I think we can delete that, push latest, and watch CI 😄

[iefremov]

@bsclifton I decided to land BraveImporter removal as a follow-up, since there are too many changes involving removing patches, etc.

[bsclifton]

All builds + tests passed; just one lint error. Gonna fix that up and merge 😄