Upgrade patches from Chromium 78.0.3904.97 to Chromium 78.0.3904.108 #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
32 tasks
bridiver
reviewed
Nov 19, 2019
| --- a/content/browser/storage_partition_impl.cc | ||
| +++ b/content/browser/storage_partition_impl.cc | ||
| @@ -1705,6 +1705,7 @@ void StoragePartitionImpl::OnCanSendReportingReports( | ||
| @@ -1708,6 +1708,7 @@ void StoragePartitionImpl::OnCanSendReportingReports( | ||
| bool allowed = permission_controller->GetPermissionStatus( | ||
| PermissionType::BACKGROUND_SYNC, origin_url, | ||
| origin_url) == blink::mojom::PermissionStatus::GRANTED; | ||
| + allowed = false; // feature disabled in Brave |
There was a problem hiding this comment.
fyi - this patch is no longer relevant afaik - cc @iefremov
mkarolin
pushed a commit
that referenced
this pull request
Nov 19, 2019
Upgrade patches from Chromium 78.0.3904.97 to Chromium 78.0.3904.108
mkarolin
pushed a commit
that referenced
this pull request
Nov 19, 2019
Upgrade patches from Chromium 78.0.3904.97 to Chromium 78.0.3904.108
mkarolin
pushed a commit
that referenced
this pull request
Nov 19, 2019
Upgrade patches from Chromium 78.0.3904.97 to Chromium 78.0.3904.108
This was referenced Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#6987
Related PR: brave/brave-browser#6990
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.