Build and use dump_syms on Windows and Mac #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing macOS to hang as well but it wasn't hanging when tested originally because I had a C63 build before it
NejcZdovc
added a commit
that referenced
this pull request
Dec 10, 2018
Adds support for getPromotion, GetPromotionCaptcha
bbondy
pushed a commit
that referenced
this pull request
Feb 18, 2019
Show browser action as disabled when shield is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already do that on Linux.
For any machine with a fresh checkout of antimuon or even muon, you'd need to do this.
I think this same thing needs to be done in muon or else create_dist will hang on win and macOS for fresh builds.
I'm going to merge this, but please comment if there are any changes that you want me to do in a follow up.