Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable credit card upload at higher level (IsCreditCardUploadEnabled) #3257

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Aug 26, 2019

which makes FormDataImporter always call
CreditCardSaveManager::AttemptToOfferCardLocalSave instead of
CreditCardSaveManager::AttemptToOfferCardUploadSave

partially resolve brave/brave-browser#5728 (third item)

Submitter Checklist:

Test Plan:

Unittest

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@darkdh darkdh requested a review from mkarolin August 26, 2019 19:46
@darkdh darkdh requested a review from bridiver as a code owner August 26, 2019 19:46
@darkdh darkdh self-assigned this Aug 26, 2019
@darkdh darkdh force-pushed the disable-cc-upload branch 2 times, most recently from 53b4987 to a3037e5 Compare August 26, 2019 21:58
@bsclifton
Copy link
Member

@darkdh can you give this a rebase? 😄

@darkdh
Copy link
Member Author

darkdh commented Sep 16, 2019

rebased

which makes FormDataImporter always call
CreditCardSaveManager::AttemptToOfferCardLocalSave instead of
CreditCardSaveManager::AttemptToOfferCardUploadSave
@darkdh darkdh merged commit a862f68 into master Sep 27, 2019
@darkdh darkdh deleted the disable-cc-upload branch September 27, 2019 20:54
@darkdh darkdh added this to the 0.72.x - Nightly milestone Sep 27, 2019
mkarolin added a commit that referenced this pull request Oct 3, 2023
The test was removed in #3257,
then re-added in #4151, but
without adding it to test/BUILD.gn. But then upstream removed the
relevant code and we removed our patch/override in
5b225e0,
so the test is no longer needed.
mkarolin added a commit that referenced this pull request Oct 12, 2023
The test was removed in #3257,
then re-added in #4151, but
without adding it to test/BUILD.gn. But then upstream removed the
relevant code and we removed our patch/override in
5b225e0,
so the test is no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up on comments for brave-syncer PR
3 participants