-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade webtorrent to 0.105.1 #2989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks like the security CI didn't like your
Any ideas? |
@feross I'll cleanup my environment and try to get a clean one that won't break CI. |
cd926a3
to
52df0e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
some ads browser tests failed on macos https://staging.ci.brave.com/job/brave-browser-build-pr/job/update_webtorrent_0.105.1/3/execution/node/645/log/, but should be unrelated to this PR, merging. |
Replace "Chrome Web Store" with "Web Store"
Fix brave/brave-browser#5358
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.