Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webtorrent to 0.105.1 #2989

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Upgrade webtorrent to 0.105.1 #2989

merged 1 commit into from
Jul 24, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Jul 23, 2019

Fix brave/brave-browser#5358

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@yrliou yrliou added this to the 0.70.x - Nightly milestone Jul 23, 2019
@yrliou yrliou requested a review from feross July 23, 2019 23:21
@yrliou yrliou self-assigned this Jul 23, 2019
feross
feross previously approved these changes Jul 23, 2019
Copy link
Contributor

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feross
Copy link
Contributor

feross commented Jul 23, 2019

Looks like the security CI didn't like your package-lock.json:

> npm audit
npm ERR! code ENOAUDIT
npm ERR! audit Your configured registry (https://registry.npmjs.org/) may not support audit requests, or the audit endpoint may be temporarily unavailable.
npm ERR! audit The server said: Invalid package tree, run  npm install  to rebuild your package-lock.json

Any ideas?

@yrliou
Copy link
Member Author

yrliou commented Jul 23, 2019

@feross I'll cleanup my environment and try to get a clean one that won't break CI.

@yrliou yrliou force-pushed the update_webtorrent_0.105.1 branch from cd926a3 to 52df0e9 Compare July 23, 2019 23:30
@yrliou yrliou requested a review from feross July 23, 2019 23:34
Copy link
Contributor

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yrliou
Copy link
Member Author

yrliou commented Jul 24, 2019

some ads browser tests failed on macos https://staging.ci.brave.com/job/brave-browser-build-pr/job/update_webtorrent_0.105.1/3/execution/node/645/log/, but should be unrelated to this PR, merging.

@yrliou yrliou merged commit d570164 into master Jul 24, 2019
@yrliou yrliou deleted the update_webtorrent_0.105.1 branch July 24, 2019 04:44
@feross feross added the feature/webtorrent Label for webtorrent related issues label Jul 24, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Replace "Chrome Web Store" with "Web Store"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/webtorrent Label for webtorrent related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebTorrent: Video streaming is broken since upgrade to WebTorrent v0.105.0
2 participants