Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failed payment balances do not retry unless browser is restarted or ad grant is claimed #2881

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 8, 2019

Fixes brave/brave-browser#5175
Uplift request for #2878

@tmancey tmancey added this to the 0.68.x - Dev milestone Jul 8, 2019
@tmancey tmancey requested a review from a team July 8, 2019 19:00
@tmancey tmancey self-assigned this Jul 8, 2019
@tmancey tmancey force-pushed the issues/5175-0.68.x branch from 00eb501 to 9039335 Compare July 8, 2019 19:31
@tmancey tmancey force-pushed the issues/5175-0.68.x branch from 9039335 to a682392 Compare July 22, 2019 07:37
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.68.x approved after deliberating with @bsclifton and @srirambv. @LaurenWags and @GeetaSarvadnya went through the cases on 0.69.x via #2878 (comment) and it looks like things are working as expected.

Please make sure that all the correct labels are being used and ensure that the appropriate issue(s) are moved into the correct milestone.

@tmancey tmancey merged commit 8043c17 into 0.68.x Jul 23, 2019
@tmancey tmancey deleted the issues/5175-0.68.x branch July 23, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants