Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add widevine sig deps into proper deps list #2698

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 14, 2019

When widevine vmp is enabled, sign_chrome_framework_for_widevine target
should be evaluated before sign_app target.

Issue: brave/brave-browser#4905

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

When widevine vmp is enabled, sign_chrome_framework_for_widevine target
should be evaluated before sign_app target.
@simonhong simonhong added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-ios Do not run CI builds for iOS labels Jun 14, 2019
@simonhong simonhong added this to the 0.68.x - Nightly milestone Jun 14, 2019
@simonhong simonhong self-assigned this Jun 14, 2019
@simonhong simonhong requested a review from mihaiplesa June 14, 2019 11:46
@simonhong simonhong merged commit 6b3e379 into master Jun 14, 2019
@simonhong simonhong deleted the enable_vmp_on_macos branch June 14, 2019 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants