Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix potential crash when launching the app from a shortcuts widget #25862

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

kylehickinson
Copy link
Collaborator

Resolves brave/brave-browser#41457

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Oct 7, 2024
@kylehickinson kylehickinson self-assigned this Oct 7, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner October 7, 2024 22:02
@kylehickinson kylehickinson merged commit 4323f0e into master Oct 8, 2024
18 checks passed
@kylehickinson kylehickinson deleted the ios-search-engine-crash branch October 8, 2024 00:56
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Oct 8, 2024
brave-builds added a commit that referenced this pull request Oct 8, 2024
brave-builds added a commit that referenced this pull request Oct 8, 2024
@brave-builds
Copy link
Collaborator

Released in v1.72.69

@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 8, 2024

Verified on iPhone 12 running iOS 17 using version 1.72 (70)

Test Scenario:

  1. Added Search shortcut widget to the Home Screen and ensured app is removed from memory.
  2. Launch Brave by tapping on Search or type URL shortcut link in the widget.
  3. Added Open a New Private tab Shortcut widget from Siri Shortcuts.
  4. Ensured that opening a Private tab using the Siri Shortcut does not cause crash when Brave is removed from memory.
Home Screen Search Widget Siri Shortcuts
IMG_7655 IMG_7656 IMG_7657

kjozwiak pushed a commit that referenced this pull request Oct 8, 2024
…get (uplift to 1.71.x) (#25866)

Uplift of #25862 (squashed) to beta
kjozwiak pushed a commit that referenced this pull request Oct 8, 2024
…get (uplift to 1.70.x) (#25867)

Uplift of #25862 (squashed) to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launching the app via the Shortcuts Widget Search button may crash
4 participants