Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coin to token before looking up token->coin when fetching SimpleHash NFTs #25154

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

nvonpentz
Copy link
Contributor

Resolves brave/brave-browser#40489

We were saving the tokens as kUnsupported - which caused issues later down the line during transfer.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Transfer a SPL token

@nvonpentz nvonpentz merged commit b15814c into master Aug 16, 2024
21 checks passed
@nvonpentz nvonpentz deleted the spl-nft-fix branch August 16, 2024 16:06
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Aug 16, 2024
brave-builds added a commit that referenced this pull request Aug 16, 2024
brave-builds added a commit that referenced this pull request Aug 16, 2024
kjozwiak pushed a commit that referenced this pull request Aug 21, 2024
…ash NFTs (uplift to 1.70.x) (#25170)

* Uplift of #25154 (squashed) to beta

* Add migration to correct spl_token_program for SPL NFTs (#25207)

* Add migration to correct spl_token_program for SPL NFTs

---------

Co-authored-by: Nick von Pentz <[email protected]>
kjozwiak pushed a commit that referenced this pull request Aug 21, 2024
…ash NFTs (uplift to 1.69.x) (#25171)

* Uplift of #25154 (squashed) to release

* Add migration to correct spl_token_program for SPL NFTs (#25207)

* Add migration to correct spl_token_program for SPL NFTs

---------

Co-authored-by: Nick von Pentz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to transfer SPL NFTs
2 participants