Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix white flash on minimize/maximize on Windows #24941

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Jul 31, 2024

Fix white flash on minimize/maximize on Windows.

Before
7gSFlHoWyg.mp4
After
UjrpbdIPgh.mp4

Resolves brave/brave-browser#40271

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov force-pushed the issues/38214-minimize-restore branch from 0e4f6cb to 8a68369 Compare July 31, 2024 15:21
@goodov goodov changed the title Fix minimize/maximize white flash on Windows. Fix white flash on minimize/maximize on Windows Jul 31, 2024
@goodov goodov force-pushed the issues/38214-minimize-restore branch from 8a68369 to dca5575 Compare August 1, 2024 06:07
@goodov goodov marked this pull request as ready for review August 1, 2024 10:17
@goodov goodov requested a review from a team as a code owner August 1, 2024 10:17
@goodov goodov requested review from simonhong and sangwoo108 August 1, 2024 10:17
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

}

SkColor BrowserDesktopWindowTreeHostWin::GetToolbarColor() const {
DCHECK(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: CHECK is prefered over DCHECK unless the expression is expensive.

@iefremov
Copy link
Contributor

iefremov commented Aug 5, 2024

for better task tracking it's better to create a new issue and link the PR to it

@goodov
Copy link
Member Author

goodov commented Aug 5, 2024

for better task tracking it's better to create a new issue and link the PR to it

created a new issue and linked with it. thanks!

@goodov goodov merged commit 4b7a08d into master Aug 5, 2024
23 checks passed
@goodov goodov deleted the issues/38214-minimize-restore branch August 5, 2024 07:23
@github-actions github-actions bot added this to the 1.70.x - Nightly milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There's a momentary white splash screen on minimize/restore on Windows
3 participants