-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the Google Hangouts extension (included by Chromium) by default. #24583
Conversation
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "policy" and so security team members have been added as reviewers to take a look. |
Fixes brave/brave-browser#39664 Disabling will add the extension to a block list. This won't affect people who have toggled the setting - for example, someone who manually enabled or disabled. Google Meet seems to work great with this extension blocked. First step towards fixing brave/brave-browser#39660 Long term goal would be to remove the extension code: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/hangout_services/manifest_v3.json;l=24-30
fafa652
to
d1e7505
Compare
A Storybook has been deployed to preview UI for the latest push |
Disabling will add the extension to a block list.
This won't affect people who have toggled the setting - for example, someone who manually enabled or disabled.
Google Meet seems to work great with this extension blocked.
Fix brave/brave-browser#39664
First step towards fixing brave/brave-browser#39660
Long term goal would be to remove the extension code: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/hangout_services/manifest_v3.json;l=24-30
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Person has never edited setting
Hangouts
should be enabled by defaultHangouts
should be disabled by defaultPerson has edited setting
Hangouts
should be enabled by default. Toggle it to OFF. Then back to ON.Hangouts
should be enabled because it was last set by the personTesting disabled is disabling the extension
Snippet courtesy of https://fedi.simonwillison.net/@simon/112757810519145581
Hangouts
to OFFnkeimhogjdpnpccoofpliimaahmaaome
"disable_reasons": [ "DISABLE_BLOCKED_BY_POLICY" ],
Testing enabling allows the extension
Snippet courtesy of https://fedi.simonwillison.net/@simon/112757810519145581
Hangouts
to ONnkeimhogjdpnpccoofpliimaahmaaome
disable_reasons
in it.