Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Truncate History Title #24491

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

Brandon-T
Copy link
Contributor

Summary

  • Fix History display titles to truncate to 2 lines and to display no title if there is none.

Resolves brave/brave-browser#39550

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Visit a page with a very long title.

  • Verify that the title in History is truncated and has a max of 2 lines.

  • Visit a page with no title

  • Verify that the title is missing and only the URL displays.

image

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jul 3, 2024
@Brandon-T Brandon-T self-assigned this Jul 3, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner July 3, 2024 19:42
Copy link
Contributor

@soner-yuksel soner-yuksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Brandon-T Brandon-T force-pushed the bugfix/HistoryTitleDisplay branch from a0bbfa8 to 259aa3b Compare July 4, 2024 14:56
@Brandon-T Brandon-T merged commit 7745bd7 into master Jul 4, 2024
19 checks passed
@Brandon-T Brandon-T deleted the bugfix/HistoryTitleDisplay branch July 4, 2024 16:56
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 4, 2024
brave-builds added a commit that referenced this pull request Jul 4, 2024
@kjozwiak
Copy link
Member

Verification PASSED on iPhone 11 running iOS 17.5.1 using the following build(s):

Brave | 1.69.101 Chromium: 127.0.6533.43 (Official Build) nightly (64-bit) 
--- | ---
Revision | 9073515479af...
OS | iOS

Using the STR/information from both #24491 (comment) & brave/brave-browser#39550 (comment), ensured that URLs with long titles only appear as two lines within History and URL's without titles only display the domain as per the following:

IMG_0358

kjozwiak pushed a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History Item Title Too Long / Not Existing
3 participants