Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Added Error Views for Premium Disconnected #24325

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Brandon-T
Copy link
Contributor

Resolves brave/brave-browser#39231

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Get rated limited or session expired when either premium or premium linked
image image

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jun 21, 2024
@Brandon-T Brandon-T self-assigned this Jun 21, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner June 21, 2024 16:49
@Brandon-T Brandon-T merged commit bc867fd into master Jun 25, 2024
20 checks passed
@Brandon-T Brandon-T deleted the bugfix/ErrorViews-Leo branch June 25, 2024 15:48
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jun 25, 2024
brave-builds added a commit that referenced this pull request Jun 25, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 9, 2024

Verified on iPhone X running iOS 16.7.8 using version 1.69 (88)

Environment: Production

Note: Deferring testing the busy error message until we get RC for 1.68. In app purchase flow for this case may take few days to complete.

Example Example Example Example
IMG_3814 IMG_3815 IMG_3817 IMG_3818

kjozwiak pushed a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] - Add Leo busy view and Leo session refresh view
3 participants