Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Enable Bitcoin by default on iOS #23970

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

StephenHeaps
Copy link
Collaborator

Resolves brave/brave-browser#38775

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@StephenHeaps
Copy link
Collaborator Author

@supermassive iOS is the last platform to enable Bitcoin (still pending security/privacy review). Should we leave the Bitcoin feature flag for now, or cleanup in this PR?

@StephenHeaps StephenHeaps force-pushed the wallet/ios-enable-bitcoin-by-default branch from 5c044f9 to bb8a147 Compare June 4, 2024 17:48
@@ -8,7 +8,7 @@ import("//build/config/features.gni")

declare_args() {
brave_infura_project_id = ""
enable_bitcoin_by_default = !is_ios
enable_bitcoin_by_default = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's drop this flag completely

Comment on lines 118 to 122
if FeatureList.kBraveWalletBitcoinFeature.enabled {
return [.eth, .sol, .fil, .btc]
} else {
return [.eth, .sol, .fil]
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think we still need this in case we have to turn off BTC via griffin

@StephenHeaps StephenHeaps force-pushed the wallet/ios-enable-bitcoin-by-default branch from 3ff7563 to 40df43d Compare June 13, 2024 14:51
@StephenHeaps StephenHeaps force-pushed the wallet/ios-enable-bitcoin-by-default branch from 40df43d to be17925 Compare June 19, 2024 18:03
@StephenHeaps StephenHeaps marked this pull request as ready for review June 26, 2024 15:44
@StephenHeaps StephenHeaps requested a review from a team as a code owner June 26, 2024 15:44
@StephenHeaps StephenHeaps merged commit 754a8d5 into master Jul 2, 2024
19 checks passed
@StephenHeaps StephenHeaps deleted the wallet/ios-enable-bitcoin-by-default branch July 2, 2024 13:45
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Bitcoin by default on iOS
3 participants