-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): Enable Bitcoin by default on iOS #23970
Conversation
@supermassive iOS is the last platform to enable Bitcoin (still pending security/privacy review). Should we leave the Bitcoin feature flag for now, or cleanup in this PR? |
5c044f9
to
bb8a147
Compare
@@ -8,7 +8,7 @@ import("//build/config/features.gni") | |||
|
|||
declare_args() { | |||
brave_infura_project_id = "" | |||
enable_bitcoin_by_default = !is_ios | |||
enable_bitcoin_by_default = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's drop this flag completely
if FeatureList.kBraveWalletBitcoinFeature.enabled { | ||
return [.eth, .sol, .fil, .btc] | ||
} else { | ||
return [.eth, .sol, .fil] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It think we still need this in case we have to turn off BTC via griffin
3ff7563
to
40df43d
Compare
40df43d
to
be17925
Compare
Resolves brave/brave-browser#38775
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: