-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): Add a debug option to enable bitcoin testnet #22971
Conversation
ios/brave-ios/Sources/Brave/Frontend/Settings/SettingsViewController.swift
Outdated
Show resolved
Hide resolved
ios/brave-ios/Sources/BraveWallet/Extensions/KeyringServiceExtensions.swift
Outdated
Show resolved
Hide resolved
5425e70
to
ea4c7d6
Compare
[puLL-Merge] - brave/brave-core@22971 DescriptionThis PR adds a new debug menu for the Brave Wallet which allows enabling the Bitcoin Testnet network and accounts. It also updates various parts of the wallet to respect the new Bitcoin Testnet preference. ChangesChanges
Various files in
Security Hotspots
In summary, the main changes look good from a security perspective. The main risk is around the unencrypted storage of the testnet preference which could be mitigated by encrypting it. Additionally, the debug menu access should be restricted if possible. |
Resolves brave/brave-browser#37256
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
In order to test this PR, you need to set up a feature flag in two ways:
If you are building this PR locally on your Xcode, duplicate Debug scheme and add --enable-features=BraveWalletBitcoin in your Arguments Passed On Launch, then build.
If you are testing using a TF build. Add BraveWalletBitcoin under Settings/BraveCore Switches/Enable Features (Enable Enable Features and a fresh launch is required)
Note: Bitcoin balance fetching will be addressed in a separate issue brave/brave-browser#36966
All BTC balance will be displayed as 0 value. Send BTC will be addressed in a separate issue brave/brave-browser#36968
In order to enable bitcoin testnet, please go to browser setting, under
Developer Options
, go toView Brave Wallet Debug Menu
. There is a toggle to turn on or off bitcoin testnet.