Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To revert C74, PR #2088 was merged unintentionally instead of #2079.
See more details here: https://bravesoftware.slack.com/archives/CA5FPHWLF/p1553697892501200?thread_ts=1553678935.487200&cid=CA5FPHWLF
Instead of re-reverting the original PR and pushing the new pr, @mihaiplesa and I worked on a PR that has the missing commits from #2079.
From #2079 :
Related: brave/brave-browser#3896
Reverts:
brave/brave-browser#3790
#2029
#2072
Fixes brave/brave-browser#3898
Unfixes:
brave/brave-browser#3502
brave/brave-browser#3662
brave/brave-browser#3816
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: