Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mojo KeyringInfo and lazy keyrings #20488

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Remove mojo KeyringInfo and lazy keyrings #20488

merged 2 commits into from
Oct 20, 2023

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Oct 11, 2023 •
edited
Loading

Resolves brave/brave-browser#33563

  • Removed mojo KeyringInfo.
  • Removed internal concept of lazy keyrings. Now when wallet is unlocked we resume all known keyrings. This allows easy enabling of new coins(like bitcoin or zcash) for existing wallets.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@supermassive supermassive requested review from a team as code owners October 11, 2023 08:31
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Oct 11, 2023
@supermassive supermassive removed request for a team October 11, 2023 08:32
@supermassive supermassive changed the title Remove keyring info Remove mojo KeyringInfo and lazy keyrings Oct 11, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Douglashdaniel
Douglashdaniel approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Wallet Front-end

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

StephenHeaps
StephenHeaps approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@StephenHeaps StephenHeaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS ++

components/brave_wallet/browser/keyring_service.cc Outdated Show resolved Hide resolved
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

kdenhartog
kdenhartog approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no concerns from sec perspective

yrliou
yrliou approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive merged commit 6b1d38c into master Oct 20, 2023
@supermassive supermassive deleted the remove_keyring_info branch October 20, 2023 03:00
@github-actions github-actions bot removed the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Oct 20, 2023
@github-actions github-actions bot added this to the 1.61.x - Nightly milestone Oct 20, 2023
bridiver
bridiver reviewed Jun 18, 2024
View reviewed changes
browser/profiles/brave_renderer_updater.cc
@@ -130,8 +130,7 @@ bool BraveRendererUpdater::CheckActiveWallet() {
if (!keyring_service_) {
return false;
}
bool is_wallet_created = keyring_service_->IsKeyringCreated(
brave_wallet::mojom::kDefaultKeyringId);
bool is_wallet_created = keyring_service_->IsWalletCreatedSync();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually an anti-pattern here for prefs that I brought up recently in the dev channel. It creates a dependency for wallet on the KeyringService that shouldn't be necessary here. I would pass the raw value of the pref and have a helper in common to replace KeyringService::IsWalletCreatedSync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenHeaps StephenHeaps StephenHeaps approved these changes

@bridiver bridiver bridiver left review comments

@Douglashdaniel Douglashdaniel Douglashdaniel approved these changes

@kdenhartog kdenhartog kdenhartog approved these changes

@yrliou yrliou yrliou approved these changes

Assignees

@supermassive supermassive

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.61.x - Release
Development

Successfully merging this pull request may close these issues.

Remove wallet's KeyringInfo
7 participants
@supermassive @brave-builds @bridiver @yrliou @StephenHeaps @kdenhartog @Douglashdaniel