Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Aggressive Fingerprinting Protection behind a flag #20316

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Hide Aggressive Fingerprinting Protection behind a flag #20316

merged 1 commit into from
Nov 1, 2023

Conversation

arthuredelstein
Copy link
Collaborator

@arthuredelstein arthuredelstein commented Sep 27, 2023 •
edited
Loading

Resolves brave/brave-browser#31229

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@arthuredelstein arthuredelstein requested review from a team as code owners September 27, 2023 17:28
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Sep 27, 2023
@pes10k
Copy link
Contributor

pes10k commented Sep 27, 2023

(please give a heads up before merging this, so i can prepare a blog post)

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

mkarolin
mkarolin approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src and strings ++. Please, add more reviewers for other files.

SergeyZhukovsky
SergeyZhukovsky approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ android part.

goodov
goodov approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@goodov goodov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src lgtm (oops, missed Max already approved).

goodov
goodov reviewed Oct 12, 2023
View reviewed changes
components/constants/pref_names.cc Outdated
@@ -46,6 +46,7 @@ const char kReferralHeaders[] = "brave.referral.headers";
const char kReferralAndroidFirstRunTimestamp[] =
"brave.referral_android_first_run_timestamp";
const char kNoScriptControlType[] = "brave.no_script_default";
const char kFingerprintingControlType[] = "brave.fingerprinting";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, why this is a preference, but not a content settings value?
can this be changed per website? If yes, then it should be stored as a "default" value for a content settings.

Copy link
Collaborator Author

@arthuredelstein arthuredelstein Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to create a toggle switch (instead of a drop-down menu) for the global setting, it was necessary to create a pref. But we are still tying both the global and per-site content settings to the respective toggle switches.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to create a toggle switch (instead of a drop-down menu) for the global setting, it was necessary to create a pref

You can create it with an empty pref. Please take a look at how forgetFirstPartyStorageControlType is implemented. It uses an empty pref and handles changes via callback.

@arthuredelstein arthuredelstein requested a review from a team as a code owner October 19, 2023 02:40
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@arthuredelstein arthuredelstein enabled auto-merge (squash) November 1, 2023 04:06
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@arthuredelstein arthuredelstein merged commit 4870753 into master Nov 1, 2023
@arthuredelstein arthuredelstein deleted the issues/31229 branch November 1, 2023 17:27
@github-actions github-actions bot added this to the 1.62.x - Nightly milestone Nov 1, 2023
@MadhaviSeelam
Copy link

@arthuredelstein can you attach a tesplan please?

mherrmann pushed a commit that referenced this pull request Nov 9, 2023
@arthuredelstein @mherrmann
Hide Aggressive Fingerprinting Protection behind a flag (#20316)
77d84a7
@arthuredelstein arthuredelstein mentioned this pull request Jan 22, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodov goodov goodov approved these changes

@mkarolin mkarolin mkarolin approved these changes

@antonok-edm antonok-edm antonok-edm approved these changes

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

Assignees

@arthuredelstein arthuredelstein

Labels
CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.

Aggressive fingerprinting mode removal
8 participants
@arthuredelstein @pes10k @brave-builds @MadhaviSeelam @goodov @SergeyZhukovsky @antonok-edm @mkarolin