Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permissions for BraveSoftware folder (Uplift to 1.56.x) #19459

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix permissions for BraveSoftware folder (Uplift to 1.56.x) #19459

merged 1 commit into from
Jul 31, 2023

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jul 27, 2023 •
edited by kjozwiak
Loading

Manual uplift of #18593
Resolves: brave/brave-browser#30546

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@spylogsster @bsclifton
Fix permissions for BraveSoftware folder (#18593)
7c22183 
Fix permissions to BraveSoftware folder
@bsclifton bsclifton added this to the 1.56.x - Release #7 milestone Jul 27, 2023
@bsclifton bsclifton requested a review from a team as a code owner July 27, 2023 18:58
@bsclifton bsclifton self-assigned this Jul 27, 2023
kjozwiak
kjozwiak approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.56.x approved 👍 QA has verified the PR on 1.57.x as per brave/brave-browser#30546 (comment).

@kjozwiak kjozwiak merged commit f5a31d2 into 1.56.x Jul 31, 2023
@kjozwiak kjozwiak deleted the brave-30546-1.56.x branch July 31, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
1.56.x - Release #7
Development

Successfully merging this pull request may close these issues.
3 participants
@bsclifton @kjozwiak @spylogsster