-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rewards verified icon #18878
Update rewards verified icon #18878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@sujitacharya2005 we should also update BAT verified icon as well in this PR. CC @Miyayes |
Yes, all places where the blue checkmark appear should be updated to the new icon. |
@deeppandya bat_verified icon is replaced with rewards_verified_tick_icon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aa054a9
to
6c806d1
Compare
Verification PASSED on
Ensured that the verification icon was replaced using the STR/Cases from #18878 (comment) & brave/brave-browser#28208 (comment) as per the following: Rewards icon in the address bar & Panel
Rewards page via
|
Example |
Example |
---|---|
![]() |
![]() |
Tipping Banner
Example |
Example |
---|---|
![]() |
![]() |
![]() |
![]() |
Uplift of #18878 (squashed) to beta
Resolves brave/brave-browser#28209
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: