Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rewards verified icon #18878

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

sujitacharya2005
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 commented Jun 13, 2023

Resolves brave/brave-browser#28209

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screenshot_20230613_120524
Screenshot_20230613_120557
Screenshot_20230613_120631

@sujitacharya2005 sujitacharya2005 added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-all-linters Do not run linters and presubmit checks labels Jun 13, 2023
Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya
Copy link
Contributor

@sujitacharya2005 we should also update BAT verified icon as well in this PR. CC @Miyayes

@Miyayes
Copy link

Miyayes commented Jun 13, 2023

@sujitacharya2005 we should also update BAT verified icon as well in this PR. CC @Miyayes

Yes, all places where the blue checkmark appear should be updated to the new icon.

@sujitacharya2005
Copy link
Contributor Author

@sujitacharya2005 we should also update BAT verified icon as well in this PR. CC @Miyayes

@deeppandya bat_verified icon is replaced with rewards_verified_tick_icon
Please let me know any other drawable or screen I have missed.

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sujitacharya2005 sujitacharya2005 force-pushed the 28209_update_rewards_verified_icon branch from aa054a9 to 6c806d1 Compare June 15, 2023 08:52
@sujitacharya2005 sujitacharya2005 merged commit 54ae619 into master Jun 15, 2023
@sujitacharya2005 sujitacharya2005 deleted the 28209_update_rewards_verified_icon branch June 15, 2023 12:04
@github-actions github-actions bot added this to the 1.54.x - Nightly milestone Jun 15, 2023
brave-builds added a commit that referenced this pull request Jun 17, 2023
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.55.3 Chromium: 115.0.5790.32 (Official Build) canary (64-bit)
--- | ---
Revision | f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS | Android 14; Build/UPB3.230519.008; 34; REL

Ensured that the verification icon was replaced using the STR/Cases from #18878 (comment) & brave/brave-browser#28208 (comment) as per the following:

Rewards icon in the address bar & Panel

Example Example
Screenshot_20230621-163912 Screenshot_20230621-164532
Screenshot_20230621-163950 Screenshot_20230621-164548
Screenshot_20230621-164224 Screenshot_20230621-164607

Rewards page via brave://settings (Tips/Monthly Tips)

Example Example
Screenshot_20230621-164156 Screenshot_20230621-164555

Tipping Banner

Example Example
Screenshot_20230621-164022 Screenshot_20230621-164626
Screenshot_20230621-164852 Screenshot_20230621-164829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-all-linters Do not run linters and presubmit checks CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Update "Verified creator" blue checkmark icon
5 participants