-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc. minor Constellation P3A updates #18340
Conversation
@@ -71,7 +72,8 @@ void StarRandomnessPoints::SendRandomnessRequest( | |||
randomness_request_state, | |||
const rust::Vec<constellation::VecU8>& rand_req_points) { | |||
auto resource_request = std::make_unique<network::ResourceRequest>(); | |||
resource_request->url = GURL(config_->star_randomness_host + "/randomness"); | |||
resource_request->url = | |||
GURL(base::StrCat({config_->star_randomness_host, "/randomness"})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is not much profit in using strcat for two strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it hurt? in terms of style, it seems like a better fit?
pls triple check all the |
3bcbeff
to
dae6039
Compare
that's true. made some corrections |
dae6039
to
401e17e
Compare
…ges in nitriding, cache attestation approved certificate fingerprint, replace DCHECKs with CHECKs
401e17e
to
6cf744f
Compare
Uplift of #18340 (squashed) to beta
Resolves brave/brave-browser#30068
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Follow test plan that will soon be defined in #14399