Add GetEthTokenSymbol and GetEthTokenDecimals to JsonRpcService #18254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvonpentz
force-pushed
the
get-eth-token-symbol
branch
from
2c31d72 to
8c1efdf
Compare
nvonpentz
force-pushed
the
get-eth-token-symbol
branch
from
91df724 to
f9b176b
Compare
nvonpentz
changed the title
nvonpentz
commented
Apr 27, 2023
| RequestInternal(eth::eth_call("", contract_address, "", "", "", data, | ||
| kEthereumBlockTagLatest), | ||
| true, network_url, std::move(internal_callback)); | ||
| } |
There was a problem hiding this comment.
Note - Jocelyn had asked that GetEthTokenSymbol and GetEthTokenDecimals share the code since they are similar, however because symbol()and decimals() return different types (string and uint8 respectively), their parsing logic is different, so I didn't see much opportunity for reuse.
|
|
||
| // Fetches decimals of an ERC20 or ERC721 token. | ||
| GetEthTokenDecimals(string chain_id, | ||
| string contract_address) => (string symbol, |
| auto internal_callback = | ||
| base::BindOnce(&JsonRpcService::OnGetEthTokenDecimals, | ||
| weak_ptr_factory_.GetWeakPtr(), std::move(callback)); | ||
| RequestInternal(eth::eth_call("", contract_address, "", "", "", data, |
There was a problem hiding this comment.
Short form please: eth_call(contract_address, data) for both methods
| "result":"$1" | ||
| })"; | ||
|
|
||
| std::string formatJsonRpcResponse(const std::string& value) { |
There was a problem hiding this comment.
formatJsonRpcResponse->FormatJsonRpcResponse
supermassive
approved these changes
Apr 28, 2023
* Rename symbol -> decimals * Rename formatJsonRpcResponse -> FormatJsonRpcResponse * Use short form of eth::eth_call
nvonpentz
force-pushed
the
get-eth-token-symbol
branch
from
f9b176b to
0106405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#29983
Exposes two APIs to the frontend, GetEthTokenSymbol and GetEthTokenDecimals, so that this data can be fetched. The first use case is for swaps with unknown tokens, however we can also use this to pre-fetch symbols when users are adding NFTs manually so they do not need to input it themselves.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: