-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): Portfolio Graph Layout Updated #18251
Conversation
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings
++
1e9890f
to
b57a2d9
Compare
A Storybook has been deployed to preview UI for the latest push |
components/brave_wallet_ui/components/desktop/views/portfolio/portfolio-asset.tsx
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/components/desktop/views/portfolio/portfolio-overview.tsx
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/components/desktop/views/portfolio/portfolio-overview.tsx
Outdated
Show resolved
Hide resolved
b57a2d9
to
d3e3abd
Compare
d3e3abd
to
d110f70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
A Storybook has been deployed to preview UI for the latest push |
Description
Updates the
Portfolio
Graph Layout to match the new designs in FigmaLine Chart Controls
menuFiat
andPercentage
change sectionsTime Line History
selectionResolves brave/brave-browser#29996
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Portfolio
tab.Time Lines
.Fiat
andPercentage
changes are accurate.Time Line
is persisted.Screen.Recording.7.mov