Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Portfolio Graph Layout Updated #18251

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

Douglashdaniel
Copy link
Contributor

Description

Updates the Portfolio Graph Layout to match the new designs in Figma

  • Adds a new Line Chart Controls menu
  • Adds Fiat and Percentage change sections
  • Persists the users Time Line History selection

Resolves brave/brave-browser#29996

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to the Portfolio tab.
  2. Test selecting different Time Lines.
  3. Test Fiat and Percentage changes are accurate.
  4. Refresh the page and make sure that your selected Time Line is persisted.
Screen.Recording.7.mov

@Douglashdaniel Douglashdaniel self-assigned this Apr 26, 2023
@Douglashdaniel Douglashdaniel requested review from a team as code owners April 26, 2023 17:56
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Apr 26, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings ++

@Douglashdaniel Douglashdaniel force-pushed the portfolio-graph-layout-updated branch from 1e9890f to b57a2d9 Compare April 27, 2023 04:49
@Douglashdaniel Douglashdaniel requested a review from darkdh April 27, 2023 04:50
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the portfolio-graph-layout-updated branch from b57a2d9 to d3e3abd Compare April 27, 2023 14:17
@Douglashdaniel Douglashdaniel force-pushed the portfolio-graph-layout-updated branch from d3e3abd to d110f70 Compare April 27, 2023 14:19
@Douglashdaniel Douglashdaniel requested a review from onyb April 27, 2023 14:20
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 717cdf1 into master Apr 27, 2023
@Douglashdaniel Douglashdaniel deleted the portfolio-graph-layout-updated branch April 27, 2023 16:41
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated Portfolio Graph Layout with New Selector
5 participants