Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharedPinnedTabService should not consider ignored Browsers in BrowserListObserver events #17969

Merged
merged 1 commit into from
May 17, 2023

Conversation

petemill
Copy link
Member

@petemill petemill commented Apr 7, 2023

Resolves brave/brave-browser#29576

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@petemill petemill requested a review from sangwoo108 April 7, 2023 16:22
@petemill petemill self-assigned this Apr 7, 2023
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks a lot

@petemill petemill force-pushed the shared-pinned-pwa-fix branch from 54f3381 to 3d752e5 Compare April 17, 2023 21:10
@petemill petemill force-pushed the shared-pinned-pwa-fix branch from 3d752e5 to b7a8042 Compare May 17, 2023 19:34
@petemill petemill merged commit 7423975 into master May 17, 2023
@petemill petemill deleted the shared-pinned-pwa-fix branch May 17, 2023 23:38
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared Pinned Tabs are attempted to be created for PWA windows
2 participants