Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway-like urls pinning support (uplift to 1.50) #17642

Closed
wants to merge 1 commit into from
Closed

Gateway-like urls pinning support (uplift to 1.50) #17642

wants to merge 1 commit into from

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Mar 16, 2023

Gateway-like urls pinning support

Uplift of #17505

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@cypt4
Gateway-like urls pinning support (#17505)
5baa09a 
* Gateway-like urls pinning support
Allow pinning of gateway-like urls
Resolves brave/brave-browser#28169
Show only pinned NFTs count in the IPFS banner
Resolves brave/brave-browser#28928
@cypt4 cypt4 requested a review from a team as a code owner March 16, 2023 14:16
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 16, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@yrliou
Copy link
Member

yrliou commented Mar 22, 2023

Closing this one since we intend to release NFT pinning in 1.51.x now.

@yrliou yrliou closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cypt4 cypt4

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cypt4 @brave-builds @yrliou