Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes youtube channel/user detection #1699

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Fixes youtube channel/user detection #1699

merged 1 commit into from
Feb 18, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Feb 16, 2019 •
edited by jasonrsadler
Loading

Resolves brave/brave-browser#3312

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc added this to the 0.63.x - Nightly milestone Feb 16, 2019
@NejcZdovc NejcZdovc self-assigned this Feb 16, 2019
@NejcZdovc NejcZdovc force-pushed the incorrect-attention branch 2 times, most recently from f2c049a to f2e774d Compare February 17, 2019 06:16
jasonrsadler
jasonrsadler previously requested changes Feb 18, 2019
View reviewed changes
@NejcZdovc NejcZdovc merged commit 5c30c66 into master Feb 18, 2019
@NejcZdovc NejcZdovc deleted the incorrect-attention branch February 18, 2019 17:09
NejcZdovc added a commit that referenced this pull request Feb 18, 2019
@NejcZdovc
Merge pull request #1699 from brave/incorrect-attention
a565a12 
Fixes youtube channel/user detection
@NejcZdovc NejcZdovc mentioned this pull request Feb 18, 2019
Merged
NejcZdovc added a commit that referenced this pull request Feb 18, 2019
@NejcZdovc
Merge pull request #1699 from brave/incorrect-attention
2882554 
Fixes youtube channel/user detection
@NejcZdovc NejcZdovc mentioned this pull request Feb 18, 2019
Merged
@btlechowski btlechowski mentioned this pull request Feb 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrsadler jasonrsadler jasonrsadler approved these changes

@ryanml ryanml Awaiting requested review from ryanml

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.63.x - Release
Development

Successfully merging this pull request may close these issues.

Verified publisher status is inconsistent in tipping panel between YouTube channel page and on a video page
3 participants
@NejcZdovc @ryanml @jasonrsadler