Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore chain ID casing #15329

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Ignore chain ID casing #15329

merged 1 commit into from
Oct 7, 2022

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 3, 2022

This fixes handling of chain IDs so comparisons are done case insensitive. Any adding to data structures happen in a lowercase way. Data structure lookups happen via lowercase values. And return values from functions use lowercase always.

This fixes several issues including custom chains in settings with uppercase values failing to add the chain due to a comparison with eth_chainId and also wallet_switchEthereumChain with uppercase values.

Resolves brave/brave-browser#25707

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bbondy bbondy requested a review from yrliou October 3, 2022 18:54
@bbondy bbondy requested a review from a team as a code owner October 3, 2022 18:54
@bbondy bbondy self-assigned this Oct 3, 2022
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Fix brave/brave-browser#25707

This fixes handling of chain IDs so comparisons are done case
insensitive.  Any adding to data structures happen in a lowercase way.
Data structure lookups happen via lowercase values. And return values
from functions use lowercase always.

This fixes several issues including custom chains in settings with
uppercase values failing to add the chain due to a comparison with
eth_chainId and also wallet_switchEthereumChain with uppercase values.
@bbondy bbondy force-pushed the chain-id-compares branch from 6a09d0f to 61456e2 Compare October 6, 2022 18:42
@bbondy bbondy merged commit 7459746 into master Oct 7, 2022
@bbondy bbondy deleted the chain-id-compares branch October 7, 2022 14:20
@bbondy bbondy added this to the 1.46.x - Nightly milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching chains with uppercase chain ID hex does not work
2 participants