Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated l10n for 1.41.x release. Part II. #14254

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#24138

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added the CI/skip-ios Do not run CI builds for iOS label Jul 20, 2022
@mkarolin mkarolin self-assigned this Jul 20, 2022
@mkarolin mkarolin requested a review from samartnik July 20, 2022 01:28
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkarolin mkarolin merged commit f80d958 into master Jul 20, 2022
@mkarolin mkarolin deleted the maxk-1.41.x-l10n-II branch July 20, 2022 16:14
@github-actions github-actions bot added this to the 1.43.x - Nightly milestone Jul 20, 2022
brave-builds pushed a commit that referenced this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update l10n for 1.41.x (Chromium 103). Part II.
2 participants