Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable flaky rewards contribution browser tests (uplift to 1.35.x) #12130

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Disable flaky rewards contribution browser tests (uplift to 1.35.x) #12130

merged 1 commit into from
Feb 4, 2022

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Feb 3, 2022 •
edited by kjozwiak
Loading

Uplift of #11826

Resolves brave/brave-browser#13883
Resolves brave/brave-browser#13884

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@zenparsing zenparsing added this to the 1.35.x - Release #2 milestone Feb 3, 2022
@zenparsing zenparsing requested a review from a team February 3, 2022 18:11
@zenparsing zenparsing requested a review from a team as a code owner February 3, 2022 18:11
@zenparsing zenparsing requested review from bsclifton and deeppandya and removed request for a team February 3, 2022 18:11
kjozwiak
kjozwiak approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.35.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit faf2e07 into 1.35.x Feb 4, 2022
@kjozwiak kjozwiak deleted the ksmith-disable-tests-1-35 branch February 4, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton bsclifton is a code owner automatically assigned from brave/rewards-client

@deeppandya deeppandya Awaiting requested review from deeppandya deeppandya is a code owner automatically assigned from brave/rewards-client

Assignees

@zenparsing zenparsing

Labels
None yet
Projects
None yet
Milestone
1.35.x - Release #2
Development

Successfully merging this pull request may close these issues.
2 participants
@zenparsing @kjozwiak