Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chrome logo to Brave logo #11540

Closed
wants to merge 2 commits into from

Conversation

EnzoItaliano
Copy link

Updates Chrome logo to Brave logo on brave://dino at the end scene of the game.

Fixes brave/brave-browser#17124

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bsclifton bsclifton requested a review from a team December 13, 2021 16:33
@bsclifton
Copy link
Member

This works great for me 😄 Makes a good starting point for some of the other issues we hav
brave-dino
e

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Dec 13, 2021

@bsclifton Can you use the bitmap file that @jonathansampson and I made for other 1-bit needs?

Jonathan - can you cross link it here?

@jonathansampson
Copy link
Contributor

Wonderful job, @EnzoItaliano!

We have been considering updates to this game for a while; I was experimenting with pixelated Brave adjustments earlier last month on Twitter. It is a challenging process; thank you for taking on the effort! (it's not trivial to get the project setup and building either, so great work!)

Here are the sprites I was working on recently:

2x

200-offline-sprite

1x

100-offline-sprite

Detail

image

We are currently looking into potential changes to the other sprite-elements as well (dinosaur, pterodactyls, cacti, etc.), so we'd like to hold onto this PR for now to see if we might be able to squeeze-in a bit more work.

@bsclifton
Copy link
Member

Quick follow up here! Do we know what else we'd like to do @bradleyrichter @jonathansampson?

@EnzoItaliano would you still be up for changes if we had some feedback? 😄

@EnzoItaliano
Copy link
Author

@bsclifton unfortunately my computer have been very bad these days, I don't know if I am able to run the project anymore

@bsclifton
Copy link
Member

Closing as stale

@bsclifton bsclifton closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the No Internet screen shows the Chrome logo when you die in the dinosaur game
5 participants