Skip to content

Commit

Permalink
Merge pull request #101 from brave/default-config-tests
Browse files Browse the repository at this point in the history
Use default config so ninja is in PATH
  • Loading branch information
garrettr authored Mar 14, 2018
2 parents 4cb2306 + 57e3693 commit 49e96ba
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions build/commands/lib/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,8 @@ const test = (suite, options) => {
'--v=' + options.v,
]

let cmdOptions = {
stdio: 'inherit',
shell: true
}

// Build the tests
util.run('ninja', ['-C', config.outputDir, suite], cmdOptions)
util.run('ninja', ['-C', config.outputDir, suite], config.defaultOptions)

let testBinary;
if (process.platform === 'win32') {
Expand All @@ -28,7 +23,7 @@ const test = (suite, options) => {
}

// Run the tests
util.run(path.join(config.outputDir, testBinary), braveArgs, cmdOptions)
util.run(path.join(config.outputDir, testBinary), braveArgs, config.defaultOptions)
}

module.exports = test
module.exports = test

0 comments on commit 49e96ba

Please sign in to comment.