Incorporate code review feedback

brave · Jun 4, 2018 · 42fba3f · 42fba3f
1 parent ba8d6b4
commit 42fba3f
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 13 deletions.
diff --git a/components/brave_shields/browser/ad_block_regional_service.cc b/components/brave_shields/browser/ad_block_regional_service.cc
@@ -27,7 +27,7 @@ namespace {
 
 std::vector<FilterList>::const_iterator FindFilterListByLocale(const std::string& locale) {
   return std::find_if(region_lists.begin(), region_lists.end(),
-                      [locale](const FilterList& filter_list) {
+                      [&locale](const FilterList& filter_list) {
                         return std::find_if(filter_list.langs.begin(),
                                             filter_list.langs.end(),
                                             [locale](const std::string& lang) {
@@ -47,11 +47,6 @@ AdBlockRegionalService::AdBlockRegionalService() {
 }
 
 AdBlockRegionalService::~AdBlockRegionalService() {
-  Cleanup();
-}
-
-void AdBlockRegionalService::Cleanup() {
-  AdBlockBaseService::Cleanup();
 }
 
 bool AdBlockRegionalService::ShouldStartRequest(const GURL& url,

diff --git a/components/brave_shields/browser/ad_block_regional_service.h b/components/brave_shields/browser/ad_block_regional_service.h
@@ -34,7 +34,6 @@ class AdBlockRegionalService : public AdBlockBaseService {
 
  protected:
   bool Init() override;
-  void Cleanup() override;
   void OnComponentRegistered(const std::string& component_id) override;
   void OnComponentReady(const std::string& component_id,
                         const base::FilePath& install_dir) override;

diff --git a/components/brave_shields/browser/ad_block_service.cc b/components/brave_shields/browser/ad_block_service.cc
@@ -30,11 +30,6 @@ AdBlockService::AdBlockService() {
 }
 
 AdBlockService::~AdBlockService() {
-  Cleanup();
-}
-
-void AdBlockService::Cleanup() {
-  AdBlockBaseService::Cleanup();
 }
 
 bool AdBlockService::ShouldStartRequest(const GURL& url,

diff --git a/components/brave_shields/browser/ad_block_service.h b/components/brave_shields/browser/ad_block_service.h
@@ -43,7 +43,6 @@ class AdBlockService : public AdBlockBaseService {
 
  protected:
   bool Init() override;
-  void Cleanup() override;
   void OnComponentReady(const std::string& component_id,
                         const base::FilePath& install_dir) override;