Merge pull request #758 from brave/fix_shields_api_test

Fix BraveShieldsExtensionApiTest time out by creating ResultCatcher b…
brave · Oct 29, 2018 · 1a13906 · 1a13906
1 parent 84dee7f
commit 1a13906
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/browser/extensions/brave_shields_apitest.cc b/browser/extensions/brave_shields_apitest.cc
@@ -25,19 +25,19 @@ class BraveShieldsExtensionApiTest : public ExtensionApiTest {
 };
 
 IN_PROC_BROWSER_TEST_F(BraveShieldsExtensionApiTest, BraveExtensionHasAccess) {
+  ResultCatcher catcher;
   const Extension* extension =
     LoadExtension(extension_dir_.AppendASCII("braveShields"));
   ASSERT_TRUE(extension);
-  ResultCatcher catcher;
   ASSERT_TRUE(catcher.GetNextResult()) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(BraveShieldsExtensionApiTest, NotBraveExtensionHasNoAccess) {
   LOG(ERROR) << "======= This is an intentional fail:";
+  ResultCatcher catcher;
   const Extension* extension =
     LoadExtension(extension_dir_.AppendASCII("notBraveShields"));
   ASSERT_TRUE(extension);
-  ResultCatcher catcher;
   ASSERT_FALSE(catcher.GetNextResult()) << message_;
 }