Added fs-repo tool for darwin extension #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spylogsster
changed the title
spylogsster
force-pushed
the
issue-16913
branch
2 times, most recently
from
7f4415c to
bccd28d
Compare
spylogsster
changed the title
lidel
reviewed
Jul 13, 2021
| sha512IPFS = '9a8b8b18c7757e5f2a0abd62dc33fc14616195b27776a967d4adff361a2becedebf286eee156af05bdbf1f39b0da5cc33264939a695a7866abe50a06b817d5cd' | ||
| break | ||
| default: | ||
| throw new Error('fs-repo migration tool download failed; unrecognized platform: ' + platform) |
There was a problem hiding this comment.
Won't this break Windows and Linux?
There was a problem hiding this comment.
This is script for out build agent, imho better to throw error immediatelly if we see wrong usage because it will be harder to figure out the reason later
There was a problem hiding this comment.
Ack. Does this mean the additional binary will only be included on macOS?
yrliou
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#16913
Added fs-repo tool into crx to make proper migrations for ipfs repo