Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 80.0.3987.149 to Chromium 81.0.4044.69. #8309

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Upgrade from Chromium 80.0.3987.149 to Chromium 81.0.4044.69. #8309

merged 4 commits into from
Mar 20, 2020

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Feb 18, 2020 •
edited
Loading

Fixes #8308
Related PR: brave/brave-core#4548

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.6.x - Nightly milestone Feb 18, 2020
@mkarolin mkarolin self-assigned this Feb 18, 2020
@mkarolin mkarolin mentioned this pull request Feb 18, 2020
Merged
32 tasks
@mkarolin mkarolin force-pushed the cr81 branch 3 times, most recently from eb3a124 to aa2dbbc Compare February 26, 2020 19:32
@mkarolin mkarolin changed the title WIP: Upgrade from Chromium 80.0.3987.100 to Chromium 81.0.4044.17. WIP: Upgrade from Chromium 80.0.3987.122 to Chromium 81.0.4044.17. Feb 26, 2020
@mkarolin mkarolin force-pushed the cr81 branch 4 times, most recently from 5a63853 to 0f6e6e9 Compare March 4, 2020 22:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mkarolin mkarolin changed the title WIP: Upgrade from Chromium 80.0.3987.122 to Chromium 81.0.4044.17. WIP: Upgrade from Chromium 80.0.3987.132 to Chromium 81.0.4044.43. Mar 4, 2020
@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
@mkarolin mkarolin marked this pull request as ready for review March 10, 2020 20:27
@mkarolin mkarolin force-pushed the cr81 branch 2 times, most recently from 284b6ef to 4046286 Compare March 11, 2020 20:45
@mkarolin mkarolin changed the title WIP: Upgrade from Chromium 80.0.3987.132 to Chromium 81.0.4044.43. WIP: Upgrade from Chromium 80.0.3987.132 to Chromium 81.0.4044.62. Mar 11, 2020
@mkarolin mkarolin changed the title WIP: Upgrade from Chromium 80.0.3987.132 to Chromium 81.0.4044.62. Upgrade from Chromium 80.0.3987.132 to Chromium 81.0.4044.62. Mar 12, 2020
@mkarolin mkarolin requested review from petemill and bsclifton March 12, 2020 16:49
@mkarolin mkarolin force-pushed the cr81 branch 4 times, most recently from f28fee7 to 5209cc4 Compare March 17, 2020 18:54
mkarolin and others added 4 commits March 19, 2020 16:04
@mkarolin
Upgrade from Chromium 80.0.3987.149 to Chromium 81.0.4044.69.
5ca7d0b
@mkarolin
Added an abitlity to patch third_party/devtools-frontend/src.
b401b90 
This is needed due to the following build errors:

TypeScript compilation failed. Used tsconfig src\out\Release\gen/third_party/devtools-frontend/src/front_end/common/color-tsconfig.json

../../../node_modules/@types/babel__generator/index.d.ts(9,20): error TS2307: Cannot find module '@babel/types'.
../../../node_modules/@types/babel__traverse/index.d.ts(10,20): error TS2307: Cannot find module '@babel/types'.
../../../node_modules/@types/babel__traverse/index.d.ts(30,5): error TS2411: Property 'scope' of type 'Scope | undefined' is not assignable to string index type '(VisitNodeFunction<S, any> & VisitNodeFunction<S, any>) | (VisitNodeFunction<S, any> & VisitNodeObject<S, any>) | (VisitNodeObject<...> & VisitNodeFunction<...>) | (VisitNodeObject<...> & VisitNodeObject<...>) | undefined'.
../../../node_modules/@types/babel__traverse/index.d.ts(31,5): error TS2411: Property 'noScope' of type 'boolean | undefined' is not assignable to string index type '(VisitNodeFunction<S, any> & VisitNodeFunction<S, any>) | (VisitNodeFunction<S, any> & VisitNodeObject<S, any>) | (VisitNodeObject<...> & VisitNodeFunction<...>) | (VisitNodeObject<...> & VisitNodeObject<...>) | undefined'.
../../../node_modules/@types/babel__template/index.d.ts(9,31): error TS2307: Cannot find module '@babel/parser'.
../../../node_modules/@types/babel__template/index.d.ts(10,54): error TS2307: Cannot find module '@babel/types'.
../../../node_modules/@types/babel__core/index.d.ts(13,20): error TS2307: Cannot find module '@babel/types'.
../../../node_modules/@types/babel__core/index.d.ts(14,31): error TS2307: Cannot find module '@babel/parser'.

There is a corresponding commit in brave-core that
patched src/third_party/devtools-frontend/src/tsconfig.json
with `"moduleResolution": "node"` entry.
@samartnik @mkarolin
[Android] Fixes for dublicate resources error on build
b9d5c60
@samartnik @mkarolin
[Android] Fix for linker error for release builds
11c94f9
@mkarolin mkarolin changed the title Upgrade from Chromium 80.0.3987.132 to Chromium 81.0.4044.62. Upgrade from Chromium 80.0.3987.149 to Chromium 81.0.4044.62. Mar 19, 2020
@mkarolin mkarolin changed the title Upgrade from Chromium 80.0.3987.149 to Chromium 81.0.4044.62. Upgrade from Chromium 80.0.3987.149 to Chromium 81.0.4044.69. Mar 19, 2020
@bsclifton bsclifton merged commit 752d27c into master Mar 20, 2020
@bsclifton bsclifton deleted the cr81 branch March 20, 2020 22:12
mkarolin pushed a commit that referenced this pull request Apr 8, 2020
@bsclifton @mkarolin
Merge pull request #8309 from brave/cr81
6a54dba 
Upgrade from Chromium 80.0.3987.149 to Chromium 81.0.4044.69.
@mkarolin mkarolin mentioned this pull request Apr 8, 2020
Merged
29 tasks
bsclifton added a commit that referenced this pull request Apr 13, 2020
@bsclifton
Merge pull request #8309 from brave/cr81
3911fae 
Upgrade from Chromium 80.0.3987.149 to Chromium 81.0.4044.69.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petemill petemill Awaiting requested review from petemill

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 80.0.3987.149 to Chromium 81.0.4044.69
4 participants
@mkarolin @bbondy @bsclifton @samartnik