Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CDN for publisher list #3242

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Use CDN for publisher list #3242

merged 1 commit into from
Feb 7, 2019
+3 −1

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Feb 6, 2019 •
edited
Loading

Partial for #3191

Core implementation: brave/brave-core#1575

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@NejcZdovc NejcZdovc added this to the 0.62.x - Nightly milestone Feb 6, 2019
@NejcZdovc NejcZdovc self-assigned this Feb 6, 2019
@NejcZdovc NejcZdovc requested a review from diracdeltas February 6, 2019 04:57
@NejcZdovc NejcZdovc mentioned this pull request Feb 6, 2019
Merged
18 tasks
diracdeltas
diracdeltas approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - i'm guessing this will have to be uplifted to whatever branch brave/brave-core#1575 ends up in?

diracdeltas
diracdeltas previously requested changes Feb 6, 2019
View reviewed changes
Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found one small issue

lib/whitelistedUrlPrefixes.js Outdated Show resolved Hide resolved
@NejcZdovc NejcZdovc requested a review from diracdeltas February 7, 2019 05:37
@diracdeltas diracdeltas merged commit 0119d46 into master Feb 7, 2019
@diracdeltas diracdeltas deleted the publisher-list-cdn branch February 7, 2019 19:20
NejcZdovc pushed a commit that referenced this pull request Feb 8, 2019
@diracdeltas @NejcZdovc
Merge pull request #3242 from brave/publisher-list-cdn
196a09f 
Use CDN for publisher list
@NejcZdovc NejcZdovc mentioned this pull request Feb 8, 2019
Merged
NejcZdovc pushed a commit that referenced this pull request Feb 8, 2019
@diracdeltas @NejcZdovc
Merge pull request #3242 from brave/publisher-list-cdn
8c3de16 
Use CDN for publisher list
@NejcZdovc NejcZdovc mentioned this pull request Feb 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diracdeltas diracdeltas diracdeltas approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.62.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @diracdeltas