Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad notifications are not shown on Windows until a non ad notification has been authorized #8932

Closed
tmancey opened this issue Mar 31, 2020 · 1 comment · Fixed by brave/brave-core#5131
Assignees
Labels

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 31, 2020

Description

Ad notifications are not shown until a non-ad notification has been authorized by the user, i.e. visiting http://bennish.net/web-notifications.html

Steps to Reproduce

  1. View an ad notification (after a fresh install, before notifications have been authorized)

Actual result:

Ad notification is not shown

Expected result:

User should be requested to authorize notifications (if not already enabled in the Windows notification settings area) and an ad notification should be shown

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Ad notifications are not requesting authorization.

Based upon diagnostic information from the Windows APIs, notifications are not enabled due to failure when initializing, likely because Brave Browser notification settings are missing from the Windows settings area.

@tmancey tmancey added bug OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/ads labels Mar 31, 2020
@tmancey tmancey self-assigned this Mar 31, 2020
@tmancey tmancey added CI/skip-android priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed CI/skip-android priority/P2 A bad problem. We might uplift this to the next planned release. labels Apr 1, 2020
@tmancey tmancey changed the title Ad notifications are not shown until a non ad notification has been authorized Ad notifications are not shown on Windows until a non ad notification has been authorized Apr 4, 2020
@kjozwiak kjozwiak removed this from the 1.9.x - Nightly milestone Apr 8, 2020
@kjozwiak kjozwiak added this to the 1.8.x - Beta milestone Apr 8, 2020
tmancey pushed a commit that referenced this issue Apr 9, 2020
Fixes ad notifications are not shown on Windows until a non ad notification has been authorized - 1.8.x
@kjozwiak kjozwiak modified the milestones: 1.8.x - Beta, 1.7.x - Release Apr 9, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 13, 2020

Verification is in progress

Brave 1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Clean profile:

  • Uninstalled existing profile and installed 1.7.x and confirmed that ads are shown and Estimated pending rewards and Ad notifications received this month stats are shown as expected
    image
  • Verified that ads history is shown as expected for viewed ads
    image
  • Verified that after installing 1.7.x. By default Brave app is shown in Notification & actions settings and status is Enabled by default
  • Verified that ads are not shown when Brave app status is disabled in Notification & action center
  • Verified that Brave app isn't shown in Notification & action center after uninstalling Brave app

Upgraded profile:

  • Verified that ads are shown in upgraded profile and Estimated pending rewards and Ad notifications received this month stats are shown as expected
  • Verified that ads history is shown as expected for viewed ads
  • Verified that ads are not shown when Brave app status is disabled in Notification & action center

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants