-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
claimed_at
db timestamp value resets to zero after sending one time or recurring tip
#8180
Comments
Unable to reproduce on Ubuntu.
After tipping the @GeetaSarvadnya make sure you close Brave when checking |
@btlechowski I did close brave and DB after every transaction to see the data in DB. |
Should be able to QA this once we get |
The issue is reported in 1.4.x. The PR brave/brave-core#4202 is not merged in 13.116 hence moving the issue out of 1.3.x hotfix. |
Verification passed on
After setting a one-time or recurring tip
Also ensured that both the promotion and promotion_creds tables were empty in publisher_info_db once the browser was restarted. Verification passed on
After setting a one-time or recurring tip
Verification PASSED on
|
Description
Found while testing #7297
claimed_at
db timestamp value resets to zero after sending one time or recurring tipSteps to Reproduce
brave.exe --rewards=staging=true
publisher_info_db
and checkpromotion
showsclaimed_at
value as0
(expected)claimed_at
value shows UGP grants claimed timestampclaimed_at
value resets to0
Actual result:
Before claiming UGP grants: Just enable rewards
![image](https://user-images.githubusercontent.com/38657976/74237741-40bec300-4cfa-11ea-8550-0f284a661d2c.png)
![image](https://user-images.githubusercontent.com/38657976/74237834-72d02500-4cfa-11ea-9bff-49ecd527d1cb.png)
![image](https://user-images.githubusercontent.com/38657976/74237928-a57a1d80-4cfa-11ea-9d5a-9a013a889d41.png)
After claiming UGP grants:
After setting one-time or recurring tip
Expected result:
claimed_at
db timestamp value should not reset to zero after sending a one-time tip or recurring tipReproduces how often:
Always
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/legacy_qa @NejcZdovc @rebron @bsclifton
The text was updated successfully, but these errors were encountered: