Appears broken translate button

[congard]

Description

[Edited Steps to Reproduce by rebron for clarification]
When you open a site in a foreign language, a translation button appears, which when clicked does not respond.

Steps to Reproduce

1. Open site in a foreign language e.g. https://www.spiegel.de/ or https://www.asahi.com/
2. Install Google translate extension
3. Notice that icon in url bar still appears and no longer does anything.
4. Icon should be hidden after Google translate extension is installed.

Actual result:

After clicked:

Expected result:

The absence of this button or it's correct behaviour (page translation)

Reproduces how often:

Always.

Brave version (brave://version info)

Brave: 1.6.2 Chromium: 80.0.3987.85
Version: 583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS: Linux

Version/Channel Information:

This can be reproduced on Brave Nightly.

Other Additional Information:

• Q: Does the issue resolve itself when disabling Brave Shields? A: No.
• Q: Does the issue resolve itself when disabling Brave Rewards? A: No.
• Q: Is the issue reproducible on the latest version of Chrome? A: Yes.

[onmyouji]

Also happens on stable
Brave 1.3.113 Chromium: 80.0.3987.87
OS: Windows 10 OS Version 1809 (Build 17763.973)

[siznax]

Also happening on

• Brave Version 1.4.95 Chromium: 80.0.3987.122 (Official Build) (64-bit)
• Mac OS Darwin 19.3.0 Darwin Kernel Version 19.3.0: Thu Jan 9 20:58:23 PST 2020; root:xnu-6153.81.5~1/RELEASE_X86_64 x86_64

example: https://github.com/2019ncovmemory/nCovMemory

[siznax]

When I try the URL above with beta, I am offered the G translate extension, which I installed, and then pressed TRANSLATE THIS PAGE on the G translate extension (not the omnibox). This causes my CPU to stress...

This does NOT happen with stable. But then again, stable does nothing. 😉

[rebron]

cc: @yrliou

[rebron]

@simonhong Was this added with Chromium 80? We hid this icon previously after a user installed Google Translate.

[rebron]

@kjozwiak is 1.5 the right milestone? Just 1.7.x. I think.

[LaurenWags]

Marking as QA/Blocked until #8082 (comment) is confirmed.

[kjozwiak]

@rebron @LaurenWags it's in the wrong milestone. It was only uplifted into 1.7.x as per brave/brave-core#4929. I must have moved it into this milestone accidentally as everything was going into 1.5.x including Android uplifts.

Thanks for the catch @rebron @LaurenWags 👍

[btlechowski]

Verification passed on

Brave	1.7.70 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Ubuntu 18.04 LTS

• Verified test plan from the description.
• Verified the icon is hidden after Google Translate Extension is hidden.
• Verified Google Translate Extension works.

Verification PASSED on macOS 10.15.3 x64 Catalina using the following build:

Brave | 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)

• Verified the STR/Test Case outlined via Appears broken translate button #8082 (comment)
• Verified the STR/Test Case outlined via Fix translation icon is visible after installing g-translate extension brave-core#4928 (comment)

Verification passed on

Brave	1.7.74 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the STR/Test Case outlined via Appears broken translate button #8082 (comment)
• Verified the STR/Test Case outlined via Fix translation icon is visible after installing g-translate extension brave-core#4928 (comment)