Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Rewards : Monthly Contribution : Copy Updates #7093

Closed
3 tasks
alexwykoff opened this issue Nov 25, 2019 · 3 comments · Fixed by brave/brave-core#4086
Closed
3 tasks

Brave Rewards : Monthly Contribution : Copy Updates #7093

alexwykoff opened this issue Nov 25, 2019 · 3 comments · Fixed by brave/brave-core#4086
Assignees
@NejcZdovc
Labels
feature/rewards l10n needs-text-change This change requires some careful wording. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.2.x - Release

Comments

@alexwykoff
Copy link

Monthly Contributions are about to migrate from Beta to production.

There are 3 spots for copy updates noticed in Nightly (1.3.30) which would reduce confusion and are being requested for implementation and uplift ahead of the migration.

The 3 locations are :

  • Monthly Contribution Banner
  • Rewards Settings : Monthly Contribution Panel
  • Rewards Settings : Pending Contributions Modal

Details are available in https://docs.google.com/document/d/19NAnjY9-TpsK2W0VN6GWAHIsrIrroAN45yERKqbcFBk/edit
@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label Nov 25, 2019
@rebron rebron added the l10n label Nov 26, 2019
@NejcZdovc NejcZdovc added this to the 1.1.x - Beta milestone Nov 26, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 27, 2019
@NejcZdovc
Updates copy for monthly flows
01ce0e2 
Resolves brave/brave-browser#7093
@NejcZdovc NejcZdovc mentioned this issue Nov 27, 2019
Merged
32 tasks
@NejcZdovc
Copy link
Contributor

partially implemented, wait for spec to be finalized

NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 4, 2019
@NejcZdovc
Updates copy for monthly flows
0409be9 
Resolves brave/brave-browser#7093
@NejcZdovc
Copy link
Contributor

Implemented completely

NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 5, 2019
@NejcZdovc
Updates copy for monthly flows
7390a1b 
Resolves brave/brave-browser#7093
bsclifton pushed a commit to brave/brave-core that referenced this issue Dec 11, 2019
@NejcZdovc @bsclifton
Updates copy for monthly flows
2c70c10 
Resolves brave/brave-browser#7093
@LaurenWags
Copy link
Member

LaurenWags commented Dec 18, 2019 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 1.2.29 Chromium: 79.0.3945.79 (Official Build) beta (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-12-18 at 2 42 03 PM

Banner for Verified Publisher (not custom):
Screen Shot 2019-12-18 at 2 42 40 PM

Custom banner for Verified Publisher:
Screen Shot 2019-12-18 at 2 42 59 PM

Monthly Contributions panel:
Screen Shot 2019-12-18 at 3 15 45 PM

Pending Contributions list:
Screen Shot 2019-12-18 at 3 19 49 PM

Verification passed on

Brave 1.2.29 Chromium: 79.0.3945.79 (Official Build) beta (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS Ubuntu 18.04 LTS

Banner for Verified Publisher (not custom):
image

Monthly Contributions panel:
image

Pending Contributions list:
image

Verification passed on

Brave 1.2.35 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Banner for Verified Publisher (not custom):
image

Custom banner for Verified Publisher:
image

Monthly Contributions panel:
image

Pending Contributions list:

image

@kjozwiak kjozwiak mentioned this issue Dec 24, 2019
Closed
97 tasks
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Dec 26, 2019
Closed
@LaurenWags LaurenWags mentioned this issue Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards l10n needs-text-change This change requires some careful wording. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.2.x - Release
Development

Successfully merging a pull request may close this issue.

Updates copy for monthly flows brave/brave-core
8 participants
@alexwykoff @kjozwiak @bsclifton @rebron @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya