Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Wallets add tokens to account button hidden in side-bar #6824

Closed
zirs3d opened this issue Nov 7, 2019 · 2 comments · Fixed by brave/ethereum-remote-client#89
Closed

Comments

@zirs3d
Copy link

zirs3d commented Nov 7, 2019

Description

On Crypto Wallets, the "Add tokens" to account Button hidden in footer of sidebar

Steps to Reproduce

  1. Open Crypto Wallets Account 1
  2. Browse the list of tokens in side-bar
  3. Add more than 3-5 tokens to the list of tokens
  4. If there is more than 3-5 tokens, the "add tokens" to account button is hidden
    in footer of sidebar, unable to scroll beyond the currently visible token items.

Actual result:

With more than 3-5 tokens, the add tokens to account button is hidden in footer of sidebar,
unable to scroll beyond the items.

Expected result:

For more than 3-5 tokens, the add tokens to account button should be visible in overflow scrolling area.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave: 0.70.122 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision: 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS: Windows 10 OS Version 1903 (Build 18362.418)

Version/Channel Information:

Current release

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    nope
  • Does the issue resolve itself when disabling Brave Rewards?
    nope
  • Is the issue reproducible on the latest version of Chrome?
    nope

Miscellaneous Information:

@srirambv srirambv added bug feature/web3/wallet Integrating Ethereum+ wallet support release-notes/exclude labels Nov 8, 2019
@srirambv srirambv added this to the Ethereum Remote Client 1.0.13 milestone Nov 8, 2019
@srirambv
Copy link
Contributor

srirambv commented Nov 8, 2019

Reproduced on BCW. Doesn't happen with MM

@srirambv
Copy link
Contributor

srirambv commented Nov 20, 2019

Verification passed on

Brave 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Linux
  • Verified able to scroll tokens in list using component 0.1.29
    image

Verification PASSED on macOS 10.15.1 x64 using 1.0.1 Chromium: 78.0.3904.108 via https://github.com/brave/ethereum-remote-client/releases/tag/0.1.29.

Screen Shot 2019-11-22 at 3 50 29 PM

------------------------ Verification passed on
Brave 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Windows 10 OS Version 1903 (Build 18362.418)
Component 0.1.29
  • Verified able to scroll tokens in list using component 0.1.29
    image

ryanml added a commit to brave/ethereum-remote-client that referenced this issue Dec 5, 2019
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants