Brave Ads still show when app are in full-screen mode

[karenkliu]

Description

Brave Rewards ads still show when watching a full-screen video on Youtube or VLC.

Steps to Reproduce

1. Go to youtube.com
2. Select a video to watch
3. Open full-screen mode

Expected result:

Brave Rewards ads should not appear when apps are in full-screen mode.

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Release Version 0.67.123 Chromium: 76.0.3809.87

[tmancey]

@srirambv As discussed I cannot reproduce, could you please update ticket with your findings too. Also @karenkliu if we could arrange a screen share if the issue re-occurs so we can diagnose the problem

[srirambv]

I am not seeing any ads when I have YT playing video in focused tab. No ads were shown when video was playing in full screen or as a standard player.

[jsecretan]

So, I can actually get this to reproduce when doing other full screen activities, like looking at a presentation. To reproduce do the following. Go to:

https://www.slideshare.net/MohammadImtiyazAhmed/the-deep-learning-technology-on-coco-framework?qid=10bdae56-cbcd-40ac-a450-1be20f377532&v=&b=&from_search=3

And select the arrows to make this full screen.

And then wait 15 seconds. Move the mouse again and an ad should appear. We should avoid ads in these cases.

[tmancey]

@jsecretan but we would need to classify a page on whether a user is working, casual browsing, shopping etc. Right now we can only detect if video or audio is playing. And only block ad notifications if video is playing in the focussed tab.

[karenkliu]

Okay, I found some examples:

1. Crunchyroll is an American distributor, publisher, licensing company and international online community focused on video streaming East Asian media including anime, manga, drama, music, electronic entertainment, and content.

2. Putlocker is an online index of hosted files and a website used for streaming entertainment media such as films and television series.

Both of these sites showed Brave Ads while the video was playing.

[rebron]

Clearing milestone.

[GeetaSarvadnya]

Verification passed on

Brave	1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from Brave Ads still show when app are in full-screen mode brave-core#3380
• Verified Streaming CNBC.com, Cnet.com, Sports news, Music, and entertainment media such as films and television series videos in full mode (app video is in full mode) and ensured there are no brave ads shown while the video was playing

Verified passed with

Brave	1.1.5 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified test plan from Brave Ads still show when app are in full-screen mode brave-core#3380
• Verified no ads displayed when Brave was in full screen mode
• Verified ads were displayed when Brave was not in full screen mode
• Verified no ads were displayed when media was playing in a tab in full screen mode (used Netflix, brave.com, cnet.com, Hulu)
• Verified no ads were displayed when media was playing in a tab which was not in full screen mode (used Netflix, brave.com, cnet.com, Hulu)
• Verified case from Brave Ads still show when app are in full-screen mode #5559 (comment)

Verification passed on

Brave	1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Ubuntu 18.04 LTS

• Verified test plan from Brave Ads still show when app are in full-screen mode brave-core#3380
• Verified no ads displayed when Brave was in full screen mode
• Verified ads were displayed when Brave was not in full screen mode
• Verified no ads were displayed when media was playing in a tab in full screen mode (used Netflix, brave.com, cnet.com, Hulu)
• Verified no ads were displayed when media was playing in a tab which was not in full screen mode (used Netflix, brave.com, cnet.com, Hulu)