Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to send from transparent to shielded account #42951

Closed
1 of 6 tasks
srirambv opened this issue Dec 18, 2024 · 3 comments · Fixed by brave/brave-core#27089
Closed
1 of 6 tasks

Unable to send from transparent to shielded account #42951

srirambv opened this issue Dec 18, 2024 · 3 comments · Fixed by brave/brave-core#27089
Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.73.x - Release #7

Comments

@srirambv
Copy link
Contributor

Description

Unable to send from transparent to shielded account

Steps to reproduce

  1. Create 2 ZCash accounts
  2. Make one account as Shielded
  3. Send from transparent account to Shielded account
  4. Shows transparent account address for Shielded account in receiving account
  5. Submit Send transaction
  6. Doesn't confirm transaction

Actual result

Unable to send from transparent to shielded account

Expected result

Should be able to send transaction from transparent address account to shielded account

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.75.105 Chromium: 132.0.6834.46 (Official Build) nightly (64-bit)
Revision 23319880bc0dddd28b9417b78040f192738dee20
OS Windows 11 Version 23H2 (Build 22631.4460)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @cypt4
@srirambv srirambv added this to Web3 Dec 18, 2024
cypt4 added a commit to brave/brave-core that referenced this issue Dec 23, 2024
@cypt4
[ZCash] Fetch consensus branch id from the backend
9acdd3a 
Resolves brave/brave-browser#42951
@cypt4 cypt4 mentioned this issue Dec 23, 2024
Merged
24 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Dec 23, 2024
@cypt4
[ZCash] Fetch consensus branch id from the backend
d082456 
Resolves brave/brave-browser#42951
@cypt4 cypt4 added p2a priority/P2 A bad problem. We might uplift this to the next planned release. and removed p2a labels Dec 24, 2024
@cypt4
Copy link

cypt4 commented Dec 24, 2024

This happens due zcash network update to the new nu6 version. Transparent transactions are also affected. Increased priority to p2.

cypt4 added a commit to brave/brave-core that referenced this issue Dec 24, 2024
@cypt4
[ZCash] Fetch consensus branch id from the backend (#27089)
1c9725d 
* [ZCash] Fetch consensus branch id from the backend
Resolves brave/brave-browser#42951
@github-project-automation github-project-automation bot moved this to Done in Web3 Dec 24, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 24, 2024
cypt4 added a commit to brave/brave-core that referenced this issue Dec 24, 2024
@cypt4
[ZCash] Fetch consensus branch id from the backend (#27089)
b86d022 
* [ZCash] Fetch consensus branch id from the backend
Resolves brave/brave-browser#42951
cypt4 added a commit to brave/brave-core that referenced this issue Dec 25, 2024
@cypt4
[ZCash] Fetch consensus branch id from the backend (#27089)
a0093bd 
* [ZCash] Fetch consensus branch id from the backend
Resolves brave/brave-browser#42951
This was referenced Dec 28, 2024
Merged
Merged
kjozwiak pushed a commit to brave/brave-core that referenced this issue Jan 6, 2025
@cypt4
[ZCash] Fetch consensus branch id from the backend - 1.74.x (#27092)
2810f96 
* [ZCash] Fetch consensus branch id from the backend (#27089)

* [ZCash] Fetch consensus branch id from the backend
Resolves brave/brave-browser#42951

* Build fix

* Presubmit fix
kjozwiak pushed a commit to brave/brave-core that referenced this issue Jan 6, 2025
@cypt4
[ZCash] Fetch consensus branch id from the backend - 1.73.x (#27094)
1ebc61c 
* [ZCash] Fetch consensus branch id from the backend (#27089)

* [ZCash] Fetch consensus branch id from the backend
Resolves brave/brave-browser#42951

* Build fix

* Presubmit fix
@kjozwiak
Copy link
Member

kjozwiak commented Jan 6, 2025

The above requires 1.73.105 or higher for 1.73.x verification 👍

@srirambv
Copy link
Contributor Author

srirambv commented Jan 8, 2025

Verification passed on

Brave 1.73.105 Chromium: 131.0.6778.265 (Official Build) (64-bit)
Revision adf1b0089a62f3ed9260e23c8cd3c7862a1e410c
OS Windows 11 Version 23H2 (Build 22631.4602)
  • Verified able to send transactions on transparent address for ZCash accounts
42951.mp4

@LaurenWags LaurenWags mentioned this issue Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.73.x - Release #7
Development

Successfully merging a pull request may close this issue.

[ZCash] Fetch consensus branch id from the backend brave/brave-core
4 participants
@kjozwiak @srirambv @brave-builds @cypt4