Download prompts can appear after switching tabs

[kylehickinson]

Description

Tapping on a link that would prompt the user to download a file can appear even after switching tabs

Steps to reproduce

1. Find a page to download something (e.g. 1Password download page)
2. Click to download or paste download URL
3. Quickly tap the + button in the toolbar to add a new tab

Actual result

Expected result

The download prompt should be tied to the tab itself and not appear when the tab has been backgrounded

Reproduces how often

Easily reproduced

Brave version

1.66 but likely an issue for a long time

Device/iOS version

iOS 17.4 (iPhone), but will be a problem on all devices/versions

Affected browser versions

• latest AppStore
• latest TestFlight
• previous TestFlight

Reproducibility

• with Brave Shields disabled
• in the latest version of mobile Safari

Miscellaneous information

No response

[iccub]

@stoletheminerals hi do you want this uplifted or can it sit in release version 1.68?

[stoletheminerals]

@iccub would be good to get it uplifted

[kjozwiak]

The above requires 1.66.120 or higher for 1.66.x verification 👍

[hffvld]

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 / iOS 17.5
- iPad Air / iPadOS 16.7.2
Brave build: 1.66.1 (120)
BraveCore: 1.66.120 (125.0.6422.165)

---

STEPS:

1. Follow the steps from Download prompts can appear after switching tabs #38551 (comment)
2. Verify

ACTUAL RESULTS:

• Verified that the download pop-up message is not shown on the NTP
• Verified that it's still possible to download a file from the correct page

---

Reproduced in 1.66 (113)

2024-06-05_13-09-53.mp4

Verified In 1.66.1 (120) on iPhone

2024-06-05_13-31-10.mp4

Verified In 1.66.1 (120) on iPad

2024-06-05_15-23-13.mp4