Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading a URL that would trigger a calendar invite doesn't work on NTP/other websites #38548

Closed
5 tasks
kylehickinson opened this issue May 24, 2024 · 2 comments · Fixed by brave/brave-core#23827

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented May 24, 2024

Description

The iOS app supports opening a Safari web view to handle adding iCal files to the users calendar but this is currently not working when you attempt to load that URL from the NTP or any website that isn't the origin of the

Steps to reproduce

  1. Paste https://developer.apple.com/wwdc24/WWDC2024_KEYNOTE.ics into the URL bar and load it from the NTP or any tab that doesn't have developer.apple.com loaded in it

Actual result

Doesn't prompt to add to calendar

Expected result

Should prompt to add to calendar

Reproduces how often

Easily reproduced

Brave version

This issue affects 1.62+

Device/iOS version

All

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kjozwiak
Copy link
Member

kjozwiak commented Jun 5, 2024

The above requires 1.66.120 or above for 1.66.x verification 👍

@hffvld
Copy link
Contributor

hffvld commented Jun 5, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.5
Brave build: 1.66.1 (120)
BraveCore: 1.66.120 (125.0.6422.165)

Filed follow-up issue #38838

STEPS:

  1. Follow the steps from Loading a URL that would trigger a calendar invite doesn't work on NTP/other websites #38548 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the prompt to add calendar event is shown on the NTP when passing a link for iCal

1 2 3
1 2 3
2024-06-05_12-15-05.mp4

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants