Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build out and enable Bridging in Wallet UI #38527

Closed
Douglashdaniel opened this issue May 23, 2024 · 1 comment · Fixed by brave/brave-core#23817
Closed

Build out and enable Bridging in Wallet UI #38527

Douglashdaniel opened this issue May 23, 2024 · 1 comment · Fixed by brave/brave-core#23817
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@Douglashdaniel
Copy link

Platforms

Linux, macOS, Windows

Description

Now that #36335 and #37212 are merged, we need to enable Bridging in the Wallet UI.

Reference our Figma designs here https://www.figma.com/design/26xCR66ZscSyVpTKrt85Hn/Transactions-2024?node-id=1-47452&t=t80kvZcDN6I0pDGo-0

Should utilize the existing Swap UI with addition information and features

  • Est time quote information
  • Recipient Allowing to select a different account to for the Receiving token.

Screenshot 1

Screenshot
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature-request feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes labels May 23, 2024
@Douglashdaniel Douglashdaniel self-assigned this May 23, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 May 23, 2024
@Douglashdaniel Douglashdaniel mentioned this issue May 23, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 May 23, 2024
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jun 6, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 6, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.69.147 Chromium: 128.0.6613.40 (Official Build) (64-bit)
Revision d29b1747d0f906239936b0d94c40889920ebf2c0
OS Windows 11 Version 23H2 (Build 22631.4037)
38527.mp4

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Enable Bridging in UI brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds