Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for LiFi cross-chain swaps #36335

Closed
onyb opened this issue Feb 23, 2024 · 2 comments · Fixed by brave/brave-core#22285
Closed

Add support for LiFi cross-chain swaps #36335

onyb opened this issue Feb 23, 2024 · 2 comments · Fixed by brave/brave-core#22285
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.65.x - Release

Comments

@onyb
Copy link
Member

onyb commented Feb 23, 2024

We want to add support for cross-chain swaps and bridging to the Swap UI in Brave Wallet. We have decided to go ahead with LiFi as our integration partner.

Docs https://apidocs.li.fi/reference/welcome-to-the-lifinance-api
Security https://github.com/brave/reviews/issues/1439
@onyb onyb added OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 23, 2024
@onyb onyb self-assigned this Feb 23, 2024
@onyb onyb added this to Web3 Feb 23, 2024
@onyb onyb mentioned this issue Feb 23, 2024
Merged
24 tasks
@onyb onyb moved this to In Review in Web3 Feb 23, 2024
@StephenHeaps StephenHeaps mentioned this issue Feb 28, 2024
Closed
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Mar 5, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Mar 5, 2024
@srirambv
Copy link
Contributor

srirambv commented Apr 1, 2024

Verification passed on

Brave 1.65.96 Chromium: 123.0.6312.86 (Official Build) beta (64-bit)
Revision 5d9143e1a0812c53bdc27fd5384591254306a88c
OS Windows 11 Version 23H2 (Build 22631.3296)
  • Verified steps from brave/brave-core#22285
  • Verified existing 0x and Jupiter swaps works as expected
  • Verified exact out swaps for EVM swaps works as expected. Entered To amount is same on Review panel
  • Encountered #35196

@srirambv
Copy link
Contributor

srirambv commented Apr 2, 2024

Verification passed on Google Pixel 8 with Android 14 running 1.65.96 x64 Beta build

  • Verified steps from brave/brave-core#22285
  • Verified existing 0x and Jupiter swaps works as expected
  • Verified exact out swaps for EVM swaps works as expected. Entered To amount is same on Review panel

@Douglashdaniel Douglashdaniel mentioned this issue May 23, 2024
Closed
@srirambv srirambv mentioned this issue Aug 19, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): add support for cross-chain swaps brave/brave-core
3 participants
@onyb @srirambv @brave-builds